Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename argv propery to args #2

Conversation

shadowspawn
Copy link

Rename argv to args to reflect more neutral meaning and usage, as suggested in pkgjs#63

Copy link
Owner

@aaronccasanova aaronccasanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shadowspawn
Copy link
Author

In case of confusion, this is a PR to your repo, so you can merge and I can't. 😄

(FYI: I'm going offline shortly, but will be back later today.)

@aaronccasanova aaronccasanova merged commit 4436ef6 into aaronccasanova:feat/restructure-options-api Feb 28, 2022
@shadowspawn shadowspawn deleted the feature/argv-to-args branch June 5, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants