Add support for Typed Arrays for issue #13 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
aaronhuggins
reviewed
Apr 5, 2022
There was a problem hiding this comment.
This is a great PR, thanks @glenne!
There are some quibbles I have with style choices you made, but I plan on doing a migration to support Deno this month in this project. So what I'll do is merge this PR as-is when I'm working on the migration and then adjust it.
I'll make sure to add your name as contributor to the README so you get full credit for your work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC8746 CBOR tags for Typed Arrays defines tags for encoding typed arrays such as Float32Array and Int16Array. By using the tags, applications can round-trip these arrays without using blobs so they retain the self-defining nature of CBOR.
This pull request adds round-trip support for Uint8Array, Int8Array, Uint16Array, Int16Array, Uint32Array, Int32Array, Float32Array and Float64Array.