Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix edge case for element missing in document #26

Merged
merged 19 commits into from
Apr 22, 2022
Merged

Fix edge case for element missing in document #26

merged 19 commits into from
Apr 22, 2022

Conversation

ahuggins-nhs
Copy link
Contributor

@ahuggins-nhs ahuggins-nhs commented Apr 8, 2021 •
edited
Loading

  • Adds mode of either strict or loose to the query engine
  • Default mode is strict
  • Mode loose will return a result for a missing element, so long as the segment which should have been it's parent exists
  • Transaction map engine uses strict mode by default, but loose can be set

boxfoot and others added 2 commits December 22, 2020 10:19
@boxfoot
Update ST header layout
74e7f5e 
Add support for ST03 element (Implementation Convention Reference)
Add mode support to the query engine
55e10ee
@ahuggins-nhs ahuggins-nhs marked this pull request as draft April 8, 2021 23:13
@ahuggins-nhs ahuggins-nhs linked an issue Apr 8, 2021 that may be closed by this pull request
Parser does not return null value for some data instead returns value from the next segment #23
Closed
@ahuggins-nhs ahuggins-nhs changed the title Fix edge case for element missing in document #23 Fix edge case for element missing in document Apr 8, 2021
@ahuggins-nhs ahuggins-nhs marked this pull request as ready for review April 8, 2021 23:49
@ahuggins-nhs
Copy link
Contributor Author

@Mohmedvaid may I include the EDI doc you provided as part of the test suite under the license for this library?

@ahuggins-nhs
Copy link
Contributor Author

@Mohmedvaid Tests pass and cover your exact use case in #23. If you approve of including the EDI file, then I will merge this and release a new version.

Keep in mind that you'll need to pass a new flag of mode='loose' when calling either X12Transaction.toObject or constructing X12TransactionMap directly.

@sonarcloud
Copy link

sonarcloud bot commented Apr 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

This was referenced Apr 22, 2022
Open
Open
@aaronhuggins aaronhuggins changed the base branch from master to main April 22, 2022 19:47
@sonarcloud
Copy link

sonarcloud bot commented Apr 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aaronhuggins aaronhuggins merged commit 2e742c8 into main Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parser does not return null value for some data instead returns value from the next segment
3 participants
@ahuggins-nhs @aaronhuggins @boxfoot