Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of ST header with 3 elements #27

Merged
merged 3 commits into from
Apr 9, 2021
Merged

Fix handling of ST header with 3 elements #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74e7f5e
Update ST header layout
boxfoot Dec 22, 2020
4934ef2
Add support for count min to segment validation
Apr 9, 2021
4e4da23
Fix verbiage and tests
Apr 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/X12Segment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ export class X12Segment {
values[15] = this.options.subElementDelimiter
}

if (values.length === enumerable.COUNT) {
if (values.length === enumerable.COUNT || values.length === enumerable.COUNT_MIN) {
for (let i = 0; i < values.length; i++) {
const name = `${this.tag}${String.prototype.padStart.call(i + 1, 2, '0')}`
const max = enumerable[name]
Expand Down Expand Up @@ -241,7 +241,9 @@ export class X12Segment {
}
} else {
throw new GeneratorError(
`Segment "${this.tag}" with ${values.length} elements does meet the required count of ${enumerable.COUNT}.`
typeof enumerable.COUNT_MIN === 'number'
? `Segment "${this.tag}" with ${values.length} elements does not meet the required count of min ${enumerable.COUNT_MIN} or max ${enumerable.COUNT}.`
: `Segment "${this.tag}" with ${values.length} elements does not meet the required count of ${enumerable.COUNT}.`
)
}
}
Expand Down
5 changes: 4 additions & 1 deletion src/X12SegmentHeader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,10 @@ export const STSegmentHeader: X12SegmentHeader = {
ST01: 3,
ST02: 9,
ST02_MIN: 4,
COUNT: 2,
ST03: 35,
ST03_MIN: 1,
COUNT: 3,
COUNT_MIN: 2,
PADDING: false
}
}
10 changes: 5 additions & 5 deletions test/GeneratorSuite.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ describe('X12Generator', () => {
}
})

it('should not generate 271 with 3 ST elements using default segment headers', () => {
it('should not generate 271 with 4 ST elements using default segment headers', () => {
const fileEdi = fs.readFileSync('test/test-data/271.edi', 'utf8').split('~')

const i = new X12Interchange()
Expand All @@ -63,13 +63,13 @@ describe('X12Generator', () => {

let error
try {
t.setHeader(fileEdi[2].split('*').slice(1))
t.setHeader([...fileEdi[2].split('*').slice(1), 'N'])
} catch (err) {
error = err.message
}

if (error !== 'Segment "ST" with 3 elements does meet the required count of 2.') {
throw new Error('271 with 3 ST elements parsing succeed which should not happen')
if (error !== 'Segment "ST" with 4 elements does not meet the required count of min 2 or max 3.') {
throw new Error('271 with 4 ST elements parsing succeed which should not happen')
}
})

Expand Down Expand Up @@ -153,7 +153,7 @@ describe('X12Generator', () => {
error = err.message
}

if (error !== 'Segment "HL" with 4 elements does meet the required count of 3.') {
if (error !== 'Segment "HL" with 4 elements does not meet the required count of 3.') {
throw new Error('271 with custom segment headers parsing succeed which should not happen')
}
})
Expand Down