Upgrade Code to AWS SDK v3 #409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rchl
reviewed
Sep 12, 2023
|
I added a new flag to set dummy creds if we do not have local credentials. (--dummy_creds, -D) Feel free to try again and review 😄 @rchl |
rchl
reviewed
Nov 22, 2023
rchl
reviewed
Nov 23, 2023
| @@ -38,15 +38,16 @@ parser.add_argument('-p', '--port', { | |||
| help: 'Port to run on (default: 8001)', | |||
| }) | |||
|
|
|||
| parser.add_argument('-D', '--dummy_creds', { | |||
| parser.add_argument('-l', '--local_config', { | |||
There was a problem hiding this comment.
It's more common to use dashes in command line options instead of underscores.
| @@ -46,41 +46,41 @@ function loadDynamoEndpoint(env, dynamoConfig) { | |||
| * @param AWS - the AWS SDK object | |||
| * @returns {{endpoint: string, sslEnabled: boolean, region: string, accessKeyId: string}} | |||
| */ | |||
| function loadDynamoConfig(env, isDummy) { | |||
| function loadDynamoConfig(env, local_config) { | |||
There was a problem hiding this comment.
camelCase convention is being used in Javascript
|
Any update on this? |
vipul0092
reviewed
Apr 1, 2024
| @@ -405,7 +405,7 @@ | |||
|
|
|||
| if (data.Items.length) { | |||
| $('#items-container').append(data.Items.map(item => { | |||
| const viewUrl = '/tables/<%= Table.TableName %>/items/' + encodeURIComponent(Object.values(item.__key).join(',')) | |||
| const viewUrl = '/tables/<%= Table.TableName %>/items/' + encodeURIComponent(Object.values(Object.values(item.__key)[0]).join(',')) | |||
There was a problem hiding this comment.
I ran this locally for my dataset, and this doesn't work properly when there are multiple keys involved, as this is only picking the first key.
I fixed this locally by doing:
Object.values(item.__key).map(function (i) { return Object.values(i)[0] }).join(',')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Upgrade AWS SDK from v2 to v3
WHY:
Incompatibility with Node 18 based platforms as AWS SDK v2 does not work well.
Note:
Thanks to this PR from @garrettheel.
I used your idea of converting the
CapacityUnitsintoNumberwhich saved me some work.