Update wal.go #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logic error
|
Fix the logic error that previousOffset is always less than offset |
aarthikrao
reviewed
May 9, 2024
| @@ -389,10 +389,10 @@ func (wal *WriteAheadLog) findStartingLogFile(offset int64, files []string) (i i | |||
| if err != nil { | |||
| return -1, -1, err | |||
| } | |||
| if previousOffset <= offset && offset <= startingOffset { | |||
|
|
|||
| if offset <= startingOffset { | |||
There was a problem hiding this comment.
The format for the file name is wal.{file_Count}.{starting_offset_in_wal_file}
Here starting_offset_in_wal_file tells us what offset the file starts from. We later increment this in the func (wal *WriteAheadLog) Replay. This offset helps us to maintain the track of the offset so far.
With the changes you have proposed, we are not updating this offset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix previousOffset is always less than offset