Search unscoped class when saving state without validation #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @larissa , Thank you for reporting issue and sending patch. Can you add specs for this case so that we don't break in future ? |
|
@anilmaurya sure! I'll add specs as soon as I get a chance. |
larissa
force-pushed
the
default-scope-inconsitency
branch
from
496d433
to
fac6904
Compare
larissa
force-pushed
the
default-scope-inconsitency
branch
from
fac6904
to
bc343b8
Compare
|
@anilmaurya I fixed specs and added a new one. Let me know if you need any changes. |
|
@larissa Thank you for contributing 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Records that are outside of
default_scopeon ActiveRecord don't transition whenskip_validation_on_save: true. I fixed the issue by searching for the record withunscoped.whereinstead of just.where.