Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last seen nodes breaks after 1092 hours #12

Closed
aattww opened this issue Jun 7, 2020 · 0 comments
Closed

Last seen nodes breaks after 1092 hours #12

aattww opened this issue Jun 7, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@aattww
Copy link
Owner

aattww commented Jun 7, 2020

Due to integer overflow, calculation of nodes seen during last 1/12/24 hours stops and remains at zero after 1092 hours (2^16 minutes).

sensors/SensorsGateway/SensorsGateway.ino

Line 357 in 9801b32

uint16_t tempTime = millis() / 60000; // Convert into minutes

@aattww aattww added the bug Something isn't working label Jun 7, 2020
@aattww aattww mentioned this issue Oct 14, 2020
Merged
@aattww aattww closed this as completed in fa64d38 Oct 14, 2020
aattww added a commit that referenced this issue Oct 14, 2020
@aattww
Merge pull request #14 from aattww/dev
265b10c 
## v1.1.3 (2020-10-14)

* Fixed number of last seen nodes zeroing after 2^16 minutes. [#12](#12)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aattww