-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to .NET Standard #255
Merged
Merged
Changes from 25 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
5634520
Multi-target net35 and netstandard1.3
nbarbettini bf26803
Working build
nbarbettini 0b421ce
Revert changes to sln
nbarbettini 8ed6a66
Revert more changes to sln
nbarbettini 77f5aae
Configure AppVeyor to use VS2017 build system
aaubry 5a0616b
Temporarily disable Unity build
aaubry 146fc5d
Add Release-DotNetCore build configuration
aaubry 2767e57
Fix the solution file
aaubry 1260c75
Log assemblyinfo contents
aaubry 972d0d8
Do not generate assemblyinfo automatically
aaubry be76ef2
Update the build command to better support .net core on linux
aaubry 7d8efac
Do not build portable class library
aaubry 1c47f83
Fix Release-DotNetCore target
aaubry 7d9934e
Add a DockerFile to build the project on Linux
aaubry 0cb4c02
Try to fix the build
aaubry 44f3015
Indicate which project is being built
aaubry d42390d
Tweak the build script and project files
aaubry 0c627a1
Only include InternalsVisibleTo on debug builds
aaubry b44a118
Add sample .NET Core application
aaubry 4ae0421
Disable culture-dependent tests that fail on Linux
aaubry 7dac5e6
Re-enable Unity prerequisites installation
aaubry cf7b62f
Attempt to fix the Unity build
aaubry ec97541
Fix the travis build
aaubry d1dfb1a
Fix the travis build (really)
aaubry d23fac5
Rename DotNetCore to DotNetStandard everywhere
aaubry d75147d
Revert changes to AssemblyInfo
aaubry ce5698e
YamlDotNet: Update AssemblyInfo.cs to consider compilation agsinst NE…
conniey e2095fe
Migrate YamlDotNet.Test.csproj to .NET Core
conniey 36c1b5f
YamlDotNet.Test: Fix errors when compiling on .NET Core
conniey 9d7838a
build.cake: Execute dotnet test for netcore builds and for all the ot…
conniey a542370
YamlDotNet.sln: Add build configuration for test project to build on …
conniey d756866
build.ps1: Add DotNetStandard builds to configuration set.
conniey c16b985
Commenting out failing tests due to differences in Culture data on Wi…
conniey c820708
build.ps1: Add DotNetStandard builds to configuration set.
conniey 4ea1442
Provide a better message when a DateTime test fails due to locale dif…
aaubry 4e4335c
Refactor the build script unit test code
aaubry ca080c4
Revert the 'buildVerbosity' argument change
aaubry cd1a0da
Disable the '-appveyor' flag on xunit
aaubry File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,43 @@ | ||
| sudo: required | ||
| dist: trusty | ||
| language: csharp | ||
| mono: | ||
| - latest | ||
|
|
||
| before_install: | ||
| - sudo apt-get update | ||
| - sudo apt-get install -y mono-xbuild libmono-microsoft-build-tasks-v4.0-4.0-cil mono-mcs | ||
| services: | ||
| - docker | ||
|
|
||
| language: generic | ||
|
|
||
| git: | ||
| depth: 9999 | ||
|
|
||
| install: | ||
| - sudo mono --aot=full /usr/lib/mono/4.5/mscorlib.dll | ||
| - sudo mono --aot=full /usr/lib/mono/gac/System/4.0.0.0__b77a5c561934e089/System.dll | ||
| - sudo mono --aot=full /usr/lib/mono/gac/System.Xml/4.0.0.0__b77a5c561934e089/System.Xml.dll | ||
| - sudo mono --aot=full /usr/lib/mono/gac/Mono.Security/4.0.0.0__0738eb9f132ed756/Mono.Security.dll | ||
| - sudo mono --aot=full /usr/lib/mono/gac/System.Configuration/4.0.0.0__b03f5f7f11d50a3a/System.Configuration.dll | ||
| - sudo mono --aot=full /usr/lib/mono/gac/System.Security/4.0.0.0__b03f5f7f11d50a3a/System.Security.dll | ||
| - sudo mono --aot=full /usr/lib/mono/gac/System.Core/4.0.0.0__b77a5c561934e089/System.Core.dll | ||
| - sudo mono --aot=full /usr/lib/mono/gac/Mono.Posix/4.0.0.0__0738eb9f132ed756/Mono.Posix.dll | ||
| - docker pull aaubry/yamldotnet | ||
|
|
||
| script: | ||
| - YamlDotNet.AotTest/run.sh | ||
| - docker run -u root -v `pwd`:/build -w /build -it aaubry/yamldotnet ./build.sh --target Test-Release-Configurations # --verbosity Diagnostic | ||
|
|
||
| # mono: | ||
| # - latest | ||
| # env: | ||
| # - DOTNETSDK=/usr/share/dotnet/sdk/1.0.3 | ||
|
|
||
| # before_install: | ||
| # - sudo sh -c 'echo "deb [arch=amd64] https://apt-mo.trafficmanager.net/repos/dotnet-release/ trusty main" > /etc/apt/sources.list.d/dotnetdev.list' | ||
| # - sudo apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv-keys 417A0893 | ||
| # - sudo apt-get update | ||
| # - sudo apt-get install -y mono-xbuild libmono-microsoft-build-tasks-v4.0-4.0-cil mono-mcs msbuild | ||
| # - sudo apt-get install -y dotnet-dev-1.0.3 | ||
|
|
||
| # install: | ||
| # - sudo mono --aot=full /usr/lib/mono/4.5/mscorlib.dll | ||
| # - sudo mono --aot=full /usr/lib/mono/gac/System/4.0.0.0__b77a5c561934e089/System.dll | ||
| # - sudo mono --aot=full /usr/lib/mono/gac/System.Xml/4.0.0.0__b77a5c561934e089/System.Xml.dll | ||
| # - sudo mono --aot=full /usr/lib/mono/gac/Mono.Security/4.0.0.0__0738eb9f132ed756/Mono.Security.dll | ||
| # - sudo mono --aot=full /usr/lib/mono/gac/System.Configuration/4.0.0.0__b03f5f7f11d50a3a/System.Configuration.dll | ||
| # - sudo mono --aot=full /usr/lib/mono/gac/System.Security/4.0.0.0__b03f5f7f11d50a3a/System.Security.dll | ||
| # - sudo mono --aot=full /usr/lib/mono/gac/System.Core/4.0.0.0__b77a5c561934e089/System.Core.dll | ||
| # - sudo mono --aot=full /usr/lib/mono/gac/Mono.Posix/4.0.0.0__0738eb9f132ed756/Mono.Posix.dll | ||
|
|
||
| # before_script: | ||
| # - dotnet restore YamlDotNet.sln | ||
|
|
||
| # script: | ||
| # - YamlDotNet.AotTest/run.sh |
Submodule BuildUtils
deleted from
a9e693
Submodule BuildUtils.UnityPrerequisites
deleted from
b83028
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to look into these failures because the tests work on Windows but not Linux. From what I could tell, Mono is having troubles trying to fetch the AM/PM designator for ko-KR (because it is always null).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment to @justinyoo , who contributed this code. Maybe he knows more about this problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@conniey @aaubry Yep, I'll have a look. In the meantime, you can comment out those lines.