Update GhoSteward #406
Merged
Update GhoSteward #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update GhoStewardV2.sol - Allowed GSM fees to be lowered - Allowed GSM exposure & borrow cap to be changed both ways * edit comment
|
JoaquinBattilana
approved these changes
May 27, 2024
| @@ -289,19 +289,19 @@ rule updateGhoBorrowCap__correctness() { | |||
| assert BORROW_CAP==newBorrowCap; | |||
|
|
|||
| uint256 borrow_cap_after = BORROW_CAP; | |||
| assert borrow_cap_before <= borrow_cap_after && to_mathint(borrow_cap_after) <= 2*borrow_cap_before; | |||
| assert to_mathint(borrow_cap_after) <= 2*borrow_cap_before; | |||
There was a problem hiding this comment.
Now the spec asserts that any cap is valid as long as it’s lower than twice the old cap 👍
| @@ -313,8 +313,7 @@ rule updateGsmExposureCap__correctness() { | |||
| assert EXPOSURE_CAP==newExposureCap; | |||
|
|
|||
| uint128 exposure_cap_after = EXPOSURE_CAP; | |||
| assert exposure_cap_before <= exposure_cap_after && | |||
| to_mathint(exposure_cap_after) <= 2*exposure_cap_before; | |||
| assert to_mathint(exposure_cap_after) <= 2*exposure_cap_before; | |||
There was a problem hiding this comment.
Now the spec asserts that any cap is valid as long as it’s lower than twice the old cap 👍
|
That's for the feedback, Steward is now compatible with latest DAO Governance decisions |
MichaelMorami
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By @marczeller