Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce unnecessary calls to generate_dataframe #36

Closed
aazuspan opened this issue Nov 14, 2022 · 0 comments · Fixed by #37
Closed

Reduce unnecessary calls to generate_dataframe #36

aazuspan opened this issue Nov 14, 2022 · 0 comments · Fixed by #37
Labels
performance Performance optimization

Comments

@aazuspan
Copy link
Owner

Currently generate_dataframe gets called quite a few times when building a plot. I doubt this is a noticeable performance hit since it's a pretty simple method, but we could clean that up by storing a df attribute when a SankeyPlot is initialized and only re-generating when the plot is updated (e.g. a class is toggled).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance optimization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant