Empty collection testing #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like Earth Engine no longer raises a specific error for sampling random points within a single point, so the error handling and testing were modified for the more specific case of an empty sampling region, e.g. a FeatureCollection with zero features. In the process, the sampling error handling was refactored and a new SamplingError class was added. SamplingError inherits from ValueError which was the previous error type, so this shouldn't affect any downstream error handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main fix is to update the failing
test_sample_data_pointtest caused by an apparent change in the EE server error handling. Previously, attempting to generate random points from a point geometry would raise an error, andsankeewould catch that and rethrow. Now, we catch more specifically when an empty feature collection is sampled.Some other minor changes:
SamplingErrorexception for all errors related to data sampling.sumin a groupby.credentialsfile rather than just therefresh_token.