Convert remaining #client to #_client #1386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonovanDMC
added a commit
to DonovanArchive/ErisPRUpdateBot
that referenced
this pull request
Jul 18, 2022
Removals: - abalabahaha/eris#1283 - abalabahaha/eris#1285 - abalabahaha/eris#1369 Additions: - abalabahaha/eris#494 - abalabahaha/eris#1193 - abalabahaha/eris#1338 - abalabahaha/eris#1386
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Channel&Shardare the only two classes that assign the Client asclientinstead of_client.If not changed to be underscored, they should at least be changed to an
Object.definePropertycall so they can be made non-enumerable.