Bump nan from 2.14.0 to 2.17.0 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The postbuild script to rebuild those packages when installing discord.js (on Node 19 for me)
with:
```
../../nan/nan_callbacks.h:55:23: error: ‘AccessorSignature’ is not a member of ‘v8’
55 | typedef v8::Local<v8::AccessorSignature> Sig;
| ^~~~~~~~~~~~~~~~~
../../nan/nan_callbacks.h:55:40: error: template argument 1 is invalid
55 | typedef v8::Local<v8::AccessorSignature> Sig;
|
```
Changelog: nodejs/nan@v2.16.0...v2.17.0
`yarn why nan` showed that those packages prefer the older versions, simply adding to my package.json
```json
"resolutions": {
"nan": "2.17.0"
},
```
fixes the issue. Not sure if there's anything better I could do
|
Can confirm this fix works for me. |
|
Sorry this got lost in my inbox, thanks |
2 tasks
abalabahaha
pushed a commit
that referenced
this pull request
Oct 28, 2023
Similar issue to #9 after NodeJS 21 v8 Upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The postbuild script to rebuild those packages when installing discord.js (on Node 19 for me) with:
Changelog: nodejs/nan@v2.16.0...v2.17.0
yarn why nanshowed that those packages prefer the older versions, simply adding to my package.jsonfixes the issue. Not sure if there's anything better I could do