Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge back to active upstream #2

Open
rzr opened this issue Dec 19, 2018 · 6 comments
Open

Merge back to active upstream #2

rzr opened this issue Dec 19, 2018 · 6 comments

Comments

@rzr
Copy link

rzr commented Dec 19, 2018

Relate-to: noble#656

This active is blocked by those pending issues/reviews:

noble#851
#1
noble#656
@rzr rzr mentioned this issue Dec 19, 2018
Open
@petersaints
Copy link

Hi, could you please also fork "bleno" (https://github.com/noble/bleno) which is part of the "noble" family and depends from "node-bluetooth-hci-socket".

@rzr
Copy link
Author

rzr commented Dec 19, 2018

Just did this:
https://www.npmjs.com/package/@abandonware/noble/v/1.9.2-0

Testing welcome

@petersaints
Copy link

You forked noble, and thanks for that. I'm talking about "bleno". "noble" implements the BLE Central Mode, whereas "bleno" implements BLE Peripherals. They complement each other.

@rzr
Copy link
Author

rzr commented Dec 19, 2018

sorry ;)
It's there
https://github.com/abandonware/bleno
Feel free to make PR, but make sure that changes are forwarded upstream first and well tracked
(mimic my changes) or read those hints:
https://www.slideshare.net/rzrfreefr/tizen-upstreamcooptdc2014pcoval/5

@rzr rzr mentioned this issue Dec 19, 2018
Open
rzr added a commit to TizenTeam/node-eddystone-beacon-scanner that referenced this issue Dec 19, 2018
@rzr
npm: Fork in abandonware npm org
18391d2 
I hope this is only temporary

Bug: sandeepmistry#26
Relate-to: abandonware/noble#2
Change-Id: I56e74e2cc8176c04177386188b905f676017e09f
Signed-off-by: Philippe Coval <p.coval@samsung.com>
rzr added a commit to TizenTeam/node-eddystone-beacon-scanner that referenced this issue Dec 19, 2018
@rzr
npm: Fork in abandonware npm org
f462f90 
I hope this is only temporary

Bug: sandeepmistry#26
Relate-to: abandonware/noble#2
Origin: abandonware#1
Change-Id: I56e74e2cc8176c04177386188b905f676017e09f
Signed-off-by: Philippe Coval <p.coval@samsung.com>
rzr added a commit to TizenTeam/node-eddystone-beacon-scanner that referenced this issue Dec 19, 2018
@rzr
npm: Fork in abandonware npm org
257a38b 
I hope this is only temporary

Bug: sandeepmistry#26
Relate-to: abandonware/noble#2
Origin: abandonware#1
Change-Id: I56e74e2cc8176c04177386188b905f676017e09f
Signed-off-by: Philippe Coval <p.coval@samsung.com>
rzr added a commit to abandonware/bleno that referenced this issue Dec 20, 2018
@rzr
npm: Update noble from abandonware org
49f62f9 
Origin: https://github.com/abandonware/bleno/pull/
Relate-to: abandonware/noble#2
Cc: @petersaints
Change-Id: I72d4f9c553a2cd1387d82884d330a4aa35c28703
Signed-off-by: Philippe Coval <p.coval@samsung.com>
rzr added a commit to abandonware/bleno that referenced this issue Dec 20, 2018
@rzr
npm: Update noble from abandonware org
e0a8953 
Origin: noble#423
Relate-to: abandonware/noble#2
Cc: @petersaints
Change-Id: I72d4f9c553a2cd1387d82884d330a4aa35c28703
Signed-off-by: Philippe Coval <p.coval@samsung.com>
@rzr rzr mentioned this issue Dec 22, 2018
Open
@rzr
Copy link
Author

rzr commented Apr 15, 2019

A new version has been released with related patches..

Relate-to: https://www.npmjs.com/package/@abandonware/noble/v/1.9.2-2

@petersaints , Bleno co-maintainers are still welcome check:

@rzr
Copy link
Author

rzr commented May 27, 2019

Relate-to: noble#886

This was referenced Jun 1, 2019
Open
Closed
@rzr rzr mentioned this issue Aug 6, 2019
Closed
@rzr rzr mentioned this issue Feb 3, 2020
Open
This was referenced Feb 19, 2020
Open
Merged
Open
rzr added a commit that referenced this issue Jan 26, 2021
@rzr
Release 1.9.2-11
35ac402 
Relate-to: #2
This was referenced Jan 26, 2021
Closed
Open
Open
Open
Open
Open
This was referenced Feb 15, 2021
Open
Open
This was referenced Feb 15, 2021
Open
Open
Closed
@rzr rzr mentioned this issue Mar 21, 2021
Open
This was referenced Sep 7, 2022
Open
Open
This was referenced Feb 6, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rzr @petersaints