Skip to content
This repository has been archived by the owner on Dec 17, 2023. It is now read-only.

Refactor time date passing #49

Merged
merged 1 commit into from
Jan 8, 2021
Merged

Conversation

Goala
Copy link
Member

@Goala Goala commented Jan 8, 2021

I also created a programm to clear the zamp_store. Needed especially when table fields are changed.

@Goala Goala requested a review from JohannesKonings January 8, 2021 08:40
*&---------------------------------------------------------------------*
*&
*&---------------------------------------------------------------------*
REPORT zamp_clear_zamp_store.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can extend that in the future to a admin report e.g. delete for specific scenarios.
We should also think about what can be the dangers to run such a program in production :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may also remove it later when the zamp_store is in a solid state.
I created an issue for that topic (https://github.com/Goala/abap-metrics-provider/issues/51)

Copy link
Member

@JohannesKonings JohannesKonings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohannesKonings JohannesKonings merged commit 4875585 into main Jan 8, 2021
@JohannesKonings JohannesKonings deleted the refactor-date-time-passing branch January 8, 2021 08:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants