-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use pangyp instead #15
Conversation
wonky spacing. |
pretty simple. 👍 |
+1..but fix spacing. my 👀 , poor 👀 |
Not my spacing! I'm doing what's there. : ) |
shouldn't we fix what's there? haha. or not. womp, womp. |
Have installed |
Sure, every time on CircleCI with iojs versions iojs-v1.2.0 and iojs-v1.3.0. Those are the versions supported on CircleCI by default: https://circleci.com/docs/environment#nodejs The error produced is:
When I edited the code to actually output the error:
Specifically: If you want, I could create a CircleCI circle.yml for this project so we could test this library on different versions. |
Thanks. I can reproduce your problem on circleci. But it's easy to specify a newer version of io.js (the one I verified working is 1.6) in your circle.yml. So I don't see the need to switch to pangyp, which I am not familiar enough to know all the catches. |
Hmm, I'm getting the same issue locally as @TakenPilot was getting on CircleCI.
|
Installed successfully on iojs@2.0.2, osx@10.8.5 via nvm. |
I also can not compile with node-gyp.
Installation with |
Using deasync on iojs currently fails because node-gyp has issue: nodejs/node-gyp#564
It's taking a long time for this issue to be fixed, so here is a branch that uses pangyp instead, so that iojs can also have deasync.
Also: actually prints any errors that occur, because otherwise they were being eaten, and it was very difficult to debug.