feat: add plotting to benchmark suites #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenodflow
reviewed
Aug 27, 2024
| if args.plot: | ||
| files = list(os.scandir(bm.result_dir)) | ||
| for file in reversed(files): | ||
| if file.name[26:-4].replace('35', '3.5') == name: |
There was a problem hiding this comment.
to extract the suite name from the result file (remove date and .csv).
zenodflow
reviewed
Aug 27, 2024
| @@ -35,7 +46,7 @@ def run(args): | |||
| print(f"Benchmark: Suite done in: {time.time() - start:.2f}s.") | |||
|
|
|||
| df = report_to_dataframe(reports) | |||
| save(df, name) | |||
| file_name = save(df, name) | |||
There was a problem hiding this comment.
The logic here could be simplified by introducing a load call in the if args.plot?
There was a problem hiding this comment.
The issue with that is we still need to pass the .csv file name into plot() so it can save the plot with the same name as the result. We can't generate the file name like here because in the if args.plot part, we are using an old result so the timestamp will be wrong if we just pass in the DataFrame.
zenodflow
requested changes
Aug 27, 2024
daiwaid
force-pushed
the
feat-benchmark-plot
branch
from
4fe75f9 to
59bce00
Compare
|
Improved version in PR #95. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
--plotflag to plot from the last benchmark suite run results.Which issue(s) this PR addresses (if any):
Addresses #
Special notes for your reviewer:
Does this PR introduce a user-facing change?