fix: add option to change LIBEM_SAMPLE_DATA_PATH in config.yaml #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is good fix. Could you also add a line or two in the benchmark/README.md to inform readers whether/what/how to configure? I.e., letting them know that they should use |
zenodflow
approved these changes
Sep 3, 2024
zenodflow
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When the libem module is installed through pip,
LIBEM_SAMPLE_DATA_PATHwill not point to the correct/desired location, so the option to change the path is needed.Which issue(s) this PR addresses (if any):
Addresses #
Special notes for your reviewer:
Does this PR introduce a user-facing change?