Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opentelemetry version, adapt to breaking changes #63

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

JT117
Copy link
Contributor

@JT117 JT117 commented Nov 14, 2024

Updated the opentelemetry, opentelemetry_sdk, opentelemetry-semantic-conventions from 0.26 to 0.27 and tracing-opentelemtry from 0.27 to 0.28.

I had to adapt certain part of the code to handle breaking changes, most notable:

  • the opentelemetry::Value enum is now marked as non_exhaustive forcing a catch all match arm
  • the TraceProvider::tracer_builder method has been removed, I use instead the tracer_with_scope

Refactored tracer initialization to use `InstrumentationScope` and updated error handling to match `opentelemetry` version 0.27. Enhanced attribute value handling for unknown values and upgraded dependencies in `Cargo.toml`.
Copy link
Owner

@abdolence abdolence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contributions and notes about your changes here as well 👍🏻

@abdolence abdolence merged commit 9ee7a0a into abdolence:master Nov 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants