-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix version specification #8
Conversation
[メモ] platform-sdkのリリース手順$ git flow release start X.X.X
$ vim CHANGELOG.md
$ poetry version X.X.X
$ git add pyproject.toml
$ git add CHANGELOG.md
$ git commit -m "bump version"
$ git flow release publish X.X.X このPRで追加されたversionコマンドでversionを確認する方法import pkg_resources
VERSION = pkg_resources.get_distribution('abeja-sdk').version ちなみにpoetry自身はどうやっているか?versionファイル作ってベタ書きしている・・・ そしてここで読み込んで poetryでもissueは立っているcloseしているが議論は終わっていない・・・ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
いろいろ調べたけどこれで動きそうなので試してみよう!
@@ -43,7 +44,7 @@ release: &release | |||
release-rc: &release-rc | |||
- checkout | |||
- *install-release-dependencies | |||
- run: poetry version $(PYTHONPATH=./ python tools/add_rc_version.py) | |||
- run: poetry version $(PYTHONPATH=./ poetry run python tools/add_rc_version.py) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
見逃してました・・・LGTM
poetryも2箇所いじってるすね... 悲しみのループ |
pip install abeja-sdk
した時に、pyproject.toml
が含まれないので、pyproject.toml
もabeja/version.py
の両方を更新するスクリプトを追加abeja.version を
pyproject.toml
から読むのではなく、pkg-resource
から読むように修正