feat: adapt probe code to allow for co64 box instead of stco #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for the correct probing of videos recorded on modern android devices
|
Thank you for your pull request!! I will update probe_test.go after merge. |
sunfish-shogi
added a commit
that referenced
this pull request
Jul 27, 2023
sunfish-shogi
added a commit
that referenced
this pull request
Jul 27, 2023
Additional changes for #135: Update test code and revert type of Sample.Size
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sunfish-shogi
This allows for the correct probing of videos recorded on modern android devices
I'm not sure if this covers all edgecases (especially with videos >4Gi) but this was sufficient for my usecase.
Let me know if you think there is a better approach!