Merge pull request #159 from abes-esr/fix_destructuration_idAbes

fix: 🐛 remplacement du foreach par un stream map
abes-esr · Jan 8, 2025 · 5bb5840 · 5bb5840
2 parents 52a46c2 + f57d8a1
commit 5bb5840
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/core/src/main/java/fr/abes/licencesnationales/core/services/EtablissementService.java b/core/src/main/java/fr/abes/licencesnationales/core/services/EtablissementService.java
@@ -95,10 +95,16 @@ public boolean existeMail(String email) {
 
     public List<EtablissementEntity> findAll() {
         List<EtablissementEntity> list = etablissementDao.findAll();
-        list.forEach(etab -> {
-            etab.setIdAbes(GenererIdAbes.genererIdAbes(etab.getIdAbes()));
-        });
-        return list;
+        return list.stream().map(e ->
+            new EtablissementEntity(
+                    e.getId(),
+                    e.getNom(),
+                    e.getSiren(),
+                    e.getTypeEtablissement(),
+                    GenererIdAbes.genererIdAbes(e.getIdAbes()),
+                    e.getContact()
+            )
+        ).collect(Collectors.toList());
     }
 
     public EtablissementEntity getUserByMail(String mail) {