Skip to content

Commit

Permalink
test: deflake an integration test (envoyproxy#36674)
Browse files Browse the repository at this point in the history
waitForAccessLog asserts the log you're waiting for is the last one. For
periodic logging on slow machines there may end up being extra log
entries so allow excess.


https://github.com/envoyproxy/envoy/actions/runs/11371697784/job/31634429494

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
  • Loading branch information
alyssawilk authored Oct 18, 2024
1 parent 5691519 commit 803aea3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/integration/protocol_integration_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@ TEST_P(ProtocolIntegrationTest, PeriodicAccessLog) {
{":method", "GET"}, {":path", "/test"}, {":scheme", "http"}, {":authority", "host.com"}});
waitForNextUpstreamRequest();
EXPECT_EQ(AccessLogType_Name(AccessLog::AccessLogType::DownstreamPeriodic),
waitForAccessLog(access_log_name_));
waitForAccessLog(access_log_name_, 0, true));

upstream_request_->encodeHeaders(Http::TestResponseHeaderMapImpl{{":status", "200"}}, true);
ASSERT_TRUE(response->waitForEndStream());
Expand Down

0 comments on commit 803aea3

Please sign in to comment.