Skip to content

Commit

Permalink
ci: Make the mobile-cc CI job run on all Envoy changes
Browse files Browse the repository at this point in the history
It's important for us to run the mobile C++ unit and integration tests
on any Envoy change. If we don't, we run the risk of breaking Envoy
Mobile with seemingly benign changes.

For example, envoyproxy#32775 caused Envoy
Mobile to permafail because an Envoy Mobile unit test wasn't run (see
envoyproxy#33158 for the fix).

This change ensures that the Envoy Mobile C++ tests run on all core
Envoy changes. There aren't too many of these tests, so it shouldn't add
much to the runtime of CI per PR.

Signed-off-by: Ali Beyad <abeyad@google.com>
  • Loading branch information
abeyad committed Mar 27, 2024
1 parent b43ea9d commit ff89c31
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions .github/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -208,14 +208,7 @@ run:
- tools/code_format/check_format.py
mobile-cc:
paths:
- .bazelrc
- .bazelversion
- .github/config.yml
- bazel/external/quiche.BUILD
- bazel/repository_locations.bzl
- mobile/.bazelrc
- mobile/**/*
- tools/code_format/check_format.py
- "**/*"
mobile-compile-time-cc:
paths:
- "**/*"
Expand Down

0 comments on commit ff89c31

Please sign in to comment.