typos

[ccoVeille]

• chore: fix typo in file name
• chore: fix wrong comments and names
• chore: fix Markdown fenced block identifiers
• chore: fix typos
• chore: fix invalid aliases for Morse decode
• chore: fix acronyms case

[ccoVeille]

Please find my reviews of your code

[abhimanyu003]

Hello @ccoVeille many thanks for your updates.
This looks great, but some test are failing, can you please fix them

[ccoVeille]

Oh really? I will check when I would be in front of a computer. I'm on phone now

[ccoVeille]

I'm a bit surprised this reported nothing 🤔

https://github.com/abhimanyu003/sttr/pull/44/checks

[ccoVeille]

Could you tellme what is failing according to you? It would help me later when I'll be ankle to check

[abhimanyu003]

Please check this one. https://github.com/abhimanyu003/sttr/actions/runs/9260275381/job/25519173373?pr=44
Also you can run go test -v ./... locally. nothing major only few minor are failing.

--- FAIL: TestBase64Decode_Command (0.00s)
    base64_test.go:127: Description() = Decode your Base64 text, want Decode your base64 text
--- FAIL: TestBase64URLDecode_Command (0.00s)
    base64url_test.go:127: Description() = Decode your Base64 text with URL Safe, want Decode your base64 text with URL Safe
--- FAIL: TestSHA1Encode_Command (0.00s)
    crypto_test.go:136: Description() = Get the SHA-1 checksum of your text, want Get the SHA1 checksum of your text
    crypto_test.go:139: FilterValue() = SHA-1 Sum (sha1), want SHA1 Sum (sha1)
    crypto_test.go:148: Title() = SHA-1 Sum (sha1), want SHA1 Sum (sha1)
--- FAIL: TestSHA256Encode_Command (0.00s)
    crypto_test.go:217: Description() = Get the SHA-256 checksum of your text, want Get the SHA256 checksum of your text
    crypto_test.go:220: FilterValue() = SHA-256 Sum (sha256), want SHA256 Sum (sha256)
    crypto_test.go:229: Title() = SHA-256 Sum (sha256), want SHA256 Sum (sha256)
--- FAIL: TestSHA224Encode_Command (0.00s)
    crypto_test.go:298: Description() = Get the SHA-224 checksum of your text, want Get the SHA224 checksum of your text
    crypto_test.go:301: FilterValue() = SHA-224 Sum (sha224), want sha224 Sum (sha224)
    crypto_test.go:310: Title() = SHA-224 Sum (sha224), want sha224 Sum (sha224)
--- FAIL: TestSHA384Encode_Command (0.00s)
    crypto_test.go:379: Description() = Get the SHA-384 checksum of your text, want Get the SHA384 checksum of your text
    crypto_test.go:382: FilterValue() = SHA-384 Sum (sha384), want sha384 Sum (sha384)
    crypto_test.go:391: Title() = SHA-384 Sum (sha384), want sha384 Sum (sha384)
--- FAIL: TestSHA512Encode_Command (0.00s)
    crypto_test.go:460: Description() = Get the SHA-512 checksum of your text, want Get the SHA512 checksum of your text
    crypto_test.go:463: FilterValue() = SHA-512 Sum (sha-512), want SHA512 Sum (sha512)
    crypto_test.go:469: Name() = sha-512, want sha512
    crypto_test.go:472: Title() = SHA-512 Sum (sha-512), want SHA512 Sum (sha512)
--- FAIL: TestBcrypt_Command (0.00s)
    crypto_test.go:549: Description() = Get the bcrypt hash of your text, want Get the Bcrypt hash of your text
    crypto_test.go:552: FilterValue() = bcrypt Hash (bcrypt), want Bcrypt Hash (bcrypt)
    crypto_test.go:561: Title() = bcrypt Hash (bcrypt), want Bcrypt Hash (bcrypt)
--- FAIL: TestMSGPACKToJSON_Command (0.00s)
    json_test.go:254: FilterValue() = MSGPACK to JSON (msgpack-json), want MSGPACK To JSON (msgpack-json)
    json_test.go:263: Title() = MSGPACK to JSON (msgpack-json), want MSGPACK To JSON (msgpack-json)
FAIL
FAIL	github.com/abhimanyu003/sttr/processors	0.765s
FAIL

[ccoVeille]

So strange, now github reports me the errors while it wasn't earlier. Did you change or trigger something?

Thanks anyway, it's clearer I will have a look when I can

[ccoVeille]

pushed back

[ccoVeille]

Im still unsure why the workflow is not triggered automatically

https://github.com/abhimanyu003/sttr/actions/runs/9289818782/usage

Does it mean you have to manually launch them ? if so, why is this set up like this?

[abhimanyu003]

Hello @ccoVeille
Thanks for your updates.
Github action didn't get triggered automatically because there is a setting that was enabled. Because of that, I have to approve your flow first.

Require approval for first-time contributors
Only first-time contributors will require approval to run workflows.

I have disabled it now. will review your PR and let you know :)

[abhimanyu003]

This is looking quite good to me. 👍 thanks so much 🙇‍♂️

[ccoVeille]

Hello @ccoVeille
Thanks for your updates.
Github action didn't get triggered automatically because there is a setting that was enabled. Because of that, I have to approve your flow first.

Require approval for first-time contributors
Only first-time contributors will require approval to run workflows.

I have disabled it now. will review your PR and let you know :)

Strange setting I have never faced until now. I learned something today 🤣

[ccoVeille]

I'm doubtful about what happened here.

I didn't change these lines on purpose.

It looks like broken conflict resolution.

I'm sorry @abhimanyu003

[abhimanyu003]

Yes, it looks like that. I will fix this. No worries on this. :)

[ccoVeille]

Same with these 2 lines that got added

[ccoVeille]

HTMLDecode here

[abhimanyu003]

I'm going to push update for this.