Skip to content

Commit

Permalink
lint: Drop paralleltest
Browse files Browse the repository at this point in the history
Enabling t.Parallel for all tests is not a good idea.
In the future, limit it to slow tests only.
  • Loading branch information
abhinav committed Oct 15, 2023
1 parent 4999223 commit 13d7b46
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ linters:
enable:
- gofumpt
- nolintlint
- paralleltest
- revive

linters-settings:
Expand Down
2 changes: 0 additions & 2 deletions ast_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ func TestBlock(t *testing.T) {
assert.True(t, b.IsRaw())
})

//nolint:paralleltest // hijacks stdout
t.Run("Dump", func(t *testing.T) {
stdout, closeStdout := hijackStdout(t)

Expand Down Expand Up @@ -69,7 +68,6 @@ func TestScript(t *testing.T) {
assert.True(t, sb.IsRaw())
})

//nolint:paralleltest // hijacks stdout
t.Run("Dump", func(t *testing.T) {
stdout, closeStdout := hijackStdout(t)

Expand Down

0 comments on commit 13d7b46

Please sign in to comment.