Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support --hostnames #1325

Merged
merged 4 commits into from
Apr 17, 2023
Merged

Support --hostnames #1325

merged 4 commits into from
Apr 17, 2023

Conversation

alexey-pelykh
Copy link
Contributor

No description provided.

@alexey-pelykh alexey-pelykh force-pushed the feature/multiple-hostnames branch 4 times, most recently from 1a4613b to f5e3add Compare March 27, 2023 15:33
@alexey-pelykh alexey-pelykh mentioned this pull request Mar 27, 2023
Open
@alexey-pelykh alexey-pelykh force-pushed the feature/multiple-hostnames branch 2 times, most recently from 461a979 to 8341ea0 Compare March 27, 2023 15:37
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided Used by chronographer to mark a PR as CHANGELOG provider label Mar 27, 2023
abhinavsingh
abhinavsingh reviewed Mar 27, 2023
View reviewed changes
Copy link
Owner

@abhinavsingh abhinavsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. PTAL at my comment related to windows & its workflow.

Thank you

proxy/proxy.py Show resolved Hide resolved
Makefile Show resolved Hide resolved
README.md Show resolved Hide resolved
proxy/common/flag.py Show resolved Hide resolved
@alexey-pelykh alexey-pelykh force-pushed the feature/multiple-hostnames branch 9 times, most recently from bc78ffc to 0942dba Compare March 29, 2023 06:38
@alexey-pelykh
Copy link
Contributor Author

@abhinavsingh your turn to tame your CI :)

@abhinavsingh
Copy link
Owner

I restarted the failed jobs. Due to certain integration tests, which uses upstream httpbin.org and pythonhosted.org, we end up receiving server side / rate limiting errors. As a result, these tests can fail sometimes. Usually, restarting them always makes them work.

@abhinavsingh
Copy link
Owner

@alexey-pelykh So workflow went fine after restarting failed jobs. Docker and GHCR are related to secrets and permissions for PRs I suppose. I'll take another stab at it sometime tonight or morrow and merge it. Thank you for adding this capability. It certainly can be used to scale proxy.py even further on a single host machine.

@alexey-pelykh
Copy link
Contributor Author

@abhinavsingh how's it going on your end? any changes needed?

@abhinavsingh
Copy link
Owner

@abhinavsingh how's it going on your end? any changes needed?

Hi @alexey-pelykh , apologies, I got derailed a release work past/this week. Promise, I'll take a look again and merge this weekend. Thank you.

@abhinavsingh
Copy link
Owner

@alexey-pelykh LGTM, made few minor edits directly in the PR. Workflow revealed failures which led me to home-assistant/core#91283 🤦‍♂️ Damn. Will need to fix the develop branch workflow before merging this PR

@abhinavsingh abhinavsingh merged commit 30574fd into abhinavsingh:develop Apr 17, 2023
@alexey-pelykh alexey-pelykh deleted the feature/multiple-hostnames branch April 17, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavsingh abhinavsingh Awaiting requested review from abhinavsingh

Assignees
No one assigned
Labels
bot:chronographer:provided Used by chronographer to mark a PR as CHANGELOG provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexey-pelykh @abhinavsingh