Skip to content

Commit

Permalink
ec2_asg: Change purge_tags default value to False (ansible-collection…
Browse files Browse the repository at this point in the history
…s#1064)

ec2_asg: Change purge_tags default value to False

SUMMARY

Changed default value of purge_tags to False.

With the addition of purge_tags to ec2_asg module ansible-collections#960, the default value was kept to True similar to many other modules in this collection and also as specified in ansible dev guide.
With this addition, the issue was discovered that there is a possibility of this change breaking existing playbooks for users if they don't update their playbooks and specify purge_tags: false where required.
This PR's change will prevent accidental breakage.
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ec2_asg

Reviewed-by: Mark Chappell <None>
Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Mark Woolley <mw@marknet15.com>
Reviewed-by: Alina Buzachis <None>
  • Loading branch information
mandar242 authored and abikouo committed Sep 18, 2023
1 parent af67561 commit 0e7dde6
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions ec2_asg.py
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@
description:
- If C(true), existing tags will be purged from the resource to match exactly what is defined by I(tags) parameter.
- If the I(tags) parameter is not set then tags will not be modified.
default: true
default: false
type: bool
version_added: 3.2.0
health_check_period:
Expand Down Expand Up @@ -1861,7 +1861,7 @@ def main():
wait_timeout=dict(type='int', default=300),
state=dict(default='present', choices=['present', 'absent']),
tags=dict(type='list', default=[], elements='dict'),
purge_tags=dict(type='bool', default=True),
purge_tags=dict(type='bool', default=False),
health_check_period=dict(type='int', default=300),
health_check_type=dict(default='EC2', choices=['EC2', 'ELB']),
default_cooldown=dict(type='int', default=300),
Expand Down

0 comments on commit 0e7dde6

Please sign in to comment.