Temporary workaround for caddy plugin error #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have this built on grugnog/caddy-docker:builder if anyone wants to test/use. |
|
Thanks for this and good to know it works for you. However, I'll be looking to build on this idea to make other plugins configurable as well. I'll leave this open for now while I find a better option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is clearly not the ideal fix for #151, but I figured it was worth pushing to a PR because the right fix looks like it might require quite a bit of improvement to caddy plugins to handle dependency versioning (as well as related changes to caddyplug and builder) and it would be nice for builder to still be functional in the mean time.