Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: enable disk resize for VZ driver #1084

Merged
merged 1 commit into from
Jul 30, 2024
Merged

core: enable disk resize for VZ driver #1084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ The VM can be customized either by passing additional flags to `colima start`.
e.g. `--cpu`, `--memory`, `--disk`, `--runtime`.
Or by editing the config file with `colima start --edit`.

**NOTE**: ~~disk size cannot be changed after the VM is created.~~ From v0.5.3, disk size can be increased when Qemu is used.
**NOTE**: ~~disk size cannot be changed after the VM is created.~~ From v0.5.3, disk size can be increased.

#### Customization Examples

Expand Down
1 change: 0 additions & 1 deletion embedded/defaults/colima.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ cpu: 2

# Size of the disk in GiB to be allocated to the virtual machine.
# NOTE: value can only be increased after virtual machine has been created.
# Increasing the disk size requires `vmType: qemu`
#
# Default: 60
disk: 60
Expand Down
5 changes: 0 additions & 5 deletions environment/vm/lima/lima.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,11 +310,6 @@ func (l *limaVM) syncDiskSize(ctx context.Context, conf config.Config) config.Co
return false
}

if conf.VMType == limaconfig.VZ {
log.Warnln("dynamic disk resize not supported for VZ driver, ignoring...")
return false
}

size := conf.Disk - instance.Disk
if size < 0 {
log.Warnln("disk size cannot be reduced, ignoring...")
Expand Down
Loading