Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECO-4943] feat: basic sending and receiving messages in the Chat #16

Merged
merged 3 commits into from
Sep 18, 2024

Commits on Sep 13, 2024

  1. feat: use Cancellation object instead of unsubscribe methods

    It's proven to be easier to manage to implement when subscription return object that you can use to unsubscribe
    ttypic committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    54ecb93 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. chore: rename Cancellation to Subscription to avoid confusions wi…

    …th coroutine cancellation
    ttypic committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    f5b2078 View commit details
    Browse the repository at this point in the history
  2. [ECO-4943] feat: basic sending and receiving messages in the Chat

    In this commit, we introduce the basic implementation for sending and receiving messages. Corner cases and potential race conditions are not the focus at this stage and will be addressed later, once Room lifecycle management is implemented and a unified test suite is set up.
    ttypic committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    14b1cfc View commit details
    Browse the repository at this point in the history