Remove Swift version check

[lawrence-forooghian]

Missed this in 67f4563.

Summary by CodeRabbit

• New Features

  • Introduced consistent extensions for ARTRealtime, ARTRealtimeChannels, and ARTRealtimeChannel, enhancing compatibility across Swift versions.

• Refactor

  • Simplified code by removing conditional compilation directives, streamlining the implementation of extensions.

[coderabbitai]

Walkthrough

The changes involve the removal of conditional compilation directives related to Swift version checks in the Ably+Dependencies.swift file. This results in the consistent definition of extensions for the ARTRealtime, ARTRealtimeChannels, and ARTRealtimeChannel classes, which now uniformly include the @retroactive @unchecked Sendable attributes across all Swift versions. The modifications streamline the code by eliminating version-specific conditions while preserving functionality.

Changes

Files	Change Summary
Sources/AblyChat/AblyCocoaExtensions/Ably+Dependencies.swift	Removed conditional compilation directives and added extensions for ARTRealtime, ARTRealtimeChannels, and ARTRealtimeChannel with @retroactive @unchecked Sendable.

Poem

In the code where rabbits hop,
We’ve tidied up, no need to stop.
Extensions now all sing the same,
Swift versions play a simpler game.
With every line, we leap with glee,
A streamlined path for you and me! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (1)

Sources/AblyChat/AblyCocoaExtensions/Ably+Dependencies.swift (1)

Line range hint 1-3: LGTM: TODO comment provides valuable context.

The TODO comment explains the use of "@unchecked Sendable" and references an external issue. This information is crucial for future maintenance.

Would you like me to create a GitHub issue to track the removal of "@unchecked Sendable" once the referenced issue is resolved?

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between dc2a7d0 and 0904bfe.

Files selected for processing (1)

• Sources/AblyChat/AblyCocoaExtensions/Ably+Dependencies.swift (1 hunks)

Additional comments not posted (3)

Sources/AblyChat/AblyCocoaExtensions/Ably+Dependencies.swift (3)

5-6: LGTM: Explanatory comment provides crucial context.

The comment explains the use of the @retroactive attribute, addressing potential Swift 6 compiler issues. It's valuable for understanding the code decisions made.

---

8-10: LGTM: Extensions correctly implemented and Swift version checks removed.

The ARTRealtimeChannels and ARTRealtimeChannel extensions are correctly implemented with the necessary protocol conformances and attributes. The removal of Swift version checks aligns with the PR objective.

Let's verify that all Swift version checks related to these extensions have been removed:

#!/bin/bash
# Description: Check for any remaining Swift version checks related to ARTRealtimeChannels and ARTRealtimeChannel extensions

# Test: Search for Swift version checks. Expect: No results.
rg --type swift '#if\s+swift\([<>=]+\d+(\.\d+)?\).*ARTRealtimeChannels'
rg --type swift '#if\s+swift\([<>=]+\d+(\.\d+)?\).*ARTRealtimeChannel'

---

6-6: LGTM: Extension correctly implemented and Swift version checks removed.

The ARTRealtime extension is correctly implemented with the necessary protocol conformance and attributes. The removal of Swift version checks aligns with the PR objective.

Let's verify that all Swift version checks related to this extension have been removed: