-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Realtime message subscription #21
Conversation
824c8db
to
1dfaab3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been offline for a few hours this afternoon so apologies for the late review submit. I wrote most of the comments in the AM but only just submitting the review as a whole now.
android/src/main/java/io/ably/flutter/plugin/AblyEventStreamHandler.java
Outdated
Show resolved
Hide resolved
android/src/main/java/io/ably/flutter/plugin/AblyEventStreamHandler.java
Outdated
Show resolved
Hide resolved
da53d26
to
7b4db0b
Compare
bb9f4f5
to
f7bf23f
Compare
f40547b
to
1624991
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions
1624991
to
eb93cb5
Compare
1. Message class cleaned up 2. only `subscribe`, forget unsubscribe - following idiomatic cancellation 3. message decoder for messages arriving from platform
Timestamp is not supported by platform channel default codec, so using long
1. stream.takeWhile will cancel on first failure 2. rename `event` and `events` to `name` and `names` to match IDL
515167b
to
d582121
Compare
Listening to messages on a Realtime Channel
This implementation follows dart idiomatic approach
Subscribing
Unsubscribing