Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/lint dart #67

Merged
merged 57 commits into from
Feb 15, 2021
Merged

Feature/lint dart #67

merged 57 commits into from
Feb 15, 2021

Conversation

tiholic
Copy link
Contributor

@tiholic tiholic commented Nov 24, 2020

Replacement for the mistakenly merged PR #49

@tiholic tiholic added this to the Stage 2 milestone Nov 24, 2020
@tiholic tiholic self-assigned this Nov 24, 2020
@tiholic tiholic force-pushed the feature/rest-channel-history branch from 75abddd to b3c6097 Compare November 24, 2020 11:26
@tiholic tiholic marked this pull request as ready for review November 24, 2020 11:31
@tiholic tiholic force-pushed the feature/lint-dart branch 2 times, most recently from 41ee031 to a0577ec Compare November 24, 2020 15:06
@tiholic tiholic force-pushed the feature/rest-channel-history branch from bc479d9 to 56ab554 Compare January 8, 2021 18:37
@tiholic tiholic force-pushed the feature/lint-dart branch from fd08700 to ec1e2e3 Compare January 9, 2021 07:31
tiholic and others added 21 commits January 12, 2021 14:13
@tiholic
using composition over category to support hasAuthCallback
ccf5ab0
@zoechi @tiholic
Basis for discussion about what linter rules to enable
9aadb40
@tiholic
removing non-nullable experimental analyzer flag
9567ec4
@tiholic
enabling missing_whitespace_between_adjacent_strings lint rule
910ed7a
@tiholic
enabling missing_whitespace_between_adjacent_strings lint rule
6ebe197
@tiholic
cleaning up some lint rules
f0875a4
@tiholic
disabling: avoid_unused_constructor_parameters, diagnostic_describe_a…
4a71562 
…ll_properties

and formatting the analysis_options.yaml
@tiholic
[dart-analyzer] changes related to "implicit-casts"
6e254a5
@tiholic
[lint] await_only_futures
582fe88
@tiholic
[lint] Applying studio auto format + lines_longer_than_80_chars
cd78fa0
@tiholic
[lint] annotate_overrides
3da2568
@tiholic
[lint] avoid_types_on_closure_parameters
cfd58d2
@tiholic
[lint] avoid_annotating_with_dynamic
ca08a9e
@tiholic
[lint] avoid_void_async
216fa8e
@tiholic
[lint] avoid_catches_without_on_clauses
ecbc1de
@tiholic
[lint] avoid_positional_boolean_parameters
580ab10
@tiholic
[lint] prefer_expression_function_bodies
110b5bd
@tiholic
[lint] unnecessary_brace_in_string_interps
23e62d6
@tiholic
[lint] avoid_function_literals_in_foreach_calls
c74a3c5
@tiholic
[lint] cascade_invocations
dc5ba3f
@tiholic
[lint] unnecessary_this
7bdc28b
tiholic and others added 23 commits January 12, 2021 14:13
@tiholic
[lint] omit_local_variable_types
0befc49
@tiholic
[lint] unused_local_variable
57ada24
@tiholic
[lint] prefer_asserts_in_initializer_lists
b558bcd
@tiholic
[lint] always_declare_return_types
7b52794
@tiholic
[lint] prefer_initializing_formals, prefer_final_fields
d93b755
@tiholic
[lint] avoid_print
ec4f1a5
@tiholic
[lint] only_throw_errors
b79d736
@tiholic
[lint] type_annotate_public_apis
dc2e9d0
@tiholic
[lint] avoid_returning_null, close_sinks
dcf53ef
@zoechi @tiholic
Update with newest lints and clean up formatting and comments
fd15cba
@tiholic
trailing comma's - saves tonnes of time by auto-formatting the dart c…
7458b4b 
…ode better
@tiholic
making necessary variables const
4ffa25c 
not sure why they were not suggested by lint!
@tiholic
asserting fetchHandle to be non-null while creating a PlatformObject
a04a581
@tiholic
using => over {}
b493d41
@tiholic
improvise documentation
0ec0e3a
@tiholic
removing analysis_options.yaml from example, so rules from package ar…
3dc1ba4 
…e applied
@tiholic
fix decoding paginated result post linting
8a03418
@tiholic
fix history list in case of no items
7bf935e
@tiholic
[lint] fixing diagnostic errors post stage 1 rebase
8b9bf63 
 Applying lint fixes to edited files
@tiholic
[lint] fixing lints post rebase over stage 1
f7b5e7d
@tiholic
[lint] fixing lints in test_integration post rebase over stage 1
1a50b6e
@tiholic
fix publishing bug - post rebase linting (stage 1)
bcf52ef 
 Addressing a bug that was introduced after fixing lints post rebasing.
@tiholic
increasing test timeout
80dff88
@tiholic tiholic mentioned this pull request Feb 15, 2021
Merged
QuintinWillison
QuintinWillison approved these changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@QuintinWillison QuintinWillison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only skim read this PR but I love it. ❤️
(what's not to love, right? 😁)

Thanks to both @tiholic and @zoechi for your hard work on this one, and my apologies for taking so long to get around to landing it (which I'll do today). 🚀

analysis_options.yaml Show resolved Hide resolved
analysis_options.yaml Show resolved Hide resolved
Base automatically changed from feature/rest-channel-history to integration/stage-2 February 15, 2021 08:54
@QuintinWillison QuintinWillison merged commit 2791a49 into integration/stage-2 Feb 15, 2021
@QuintinWillison QuintinWillison deleted the feature/lint-dart branch February 15, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuintinWillison QuintinWillison QuintinWillison approved these changes

Assignees

@tiholic tiholic

Labels
None yet
Milestone
Stage 1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@tiholic @QuintinWillison @zoechi