Merge pull request #1243 from ably/remove-property-setting-in-platfor…

…m-index Remove unnecessary property setting in platforms’ `index.ts` files
ably · May 10, 2023 · 1ee341c · 1ee341c
2 parents ad3e743 + bb480b0
commit 1ee341c
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 57 deletions.
diff --git a/src/common/lib/client/rest.ts b/src/common/lib/client/rest.ts
@@ -241,8 +241,8 @@ class Rest {
   static Callbacks = Rest;
   static Platform = Platform;
   static Crypto?: typeof Platform.Crypto;
-  static Message?: typeof Message;
-  static PresenceMessage?: typeof PresenceMessage;
+  static Message = Message;
+  static PresenceMessage = PresenceMessage;
 }
 
 class Channels {

diff --git a/src/platform/nativescript/index.ts b/src/platform/nativescript/index.ts
@@ -14,13 +14,10 @@ import Config from './config';
 import Transports from '../web/lib/transport';
 import Logger from '../../common/lib/util/logger';
 import { getDefaults } from '../../common/lib/util/defaults';
-import ConnectionManager from '../../common/lib/transport/connectionmanager';
 // @ts-ignore
 import WebStorage from './lib/util/webstorage';
 import PlatformDefaults from '../web/lib/util/defaults';
 import msgpack from '../web/lib/util/msgpack';
-import Message from 'common/lib/types/message';
-import PresenceMessage from 'common/lib/types/presencemessage';
 
 Platform.Crypto = Crypto;
 Platform.BufferUtils = BufferUtils;
@@ -32,14 +29,6 @@ Platform.WebStorage = WebStorage;
 Rest.Crypto = Crypto;
 Realtime.Crypto = Crypto;
 
-Rest.Message = Message;
-Realtime.Message = Message;
-
-Rest.PresenceMessage = PresenceMessage;
-Realtime.PresenceMessage = PresenceMessage;
-
-Realtime.ConnectionManager = ConnectionManager;
-
 Logger.initLogHandlers();
 
 Platform.Defaults = getDefaults(PlatformDefaults);

diff --git a/src/platform/nodejs/index.ts b/src/platform/nodejs/index.ts
@@ -13,10 +13,7 @@ import Config from './config';
 import Transports from './lib/transport';
 import Logger from '../../common/lib/util/logger';
 import { getDefaults } from '../../common/lib/util/defaults';
-import ConnectionManager from '../../common/lib/transport/connectionmanager';
 import PlatformDefaults from './lib/util/defaults';
-import Message from 'common/lib/types/message';
-import PresenceMessage from 'common/lib/types/presencemessage';
 
 Platform.Crypto = Crypto;
 Platform.BufferUtils = BufferUtils;
@@ -28,14 +25,6 @@ Platform.WebStorage = null;
 Rest.Crypto = Crypto;
 Realtime.Crypto = Crypto;
 
-Rest.Message = Message;
-Realtime.Message = Message;
-
-Rest.PresenceMessage = PresenceMessage;
-Realtime.PresenceMessage = PresenceMessage;
-
-Realtime.ConnectionManager = ConnectionManager;
-
 Logger.initLogHandlers();
 
 Platform.Defaults = getDefaults(PlatformDefaults);

diff --git a/src/platform/react-native/index.ts b/src/platform/react-native/index.ts
@@ -13,12 +13,9 @@ import Config from './config';
 import Transports from '../web/lib/transport';
 import Logger from '../../common/lib/util/logger';
 import { getDefaults } from '../../common/lib/util/defaults';
-import ConnectionManager from '../../common/lib/transport/connectionmanager';
 import WebStorage from '../web/lib/util/webstorage';
 import PlatformDefaults from '../web/lib/util/defaults';
 import msgpack from '../web/lib/util/msgpack';
-import Message from 'common/lib/types/message';
-import PresenceMessage from 'common/lib/types/presencemessage';
 
 Platform.Crypto = Crypto;
 Platform.BufferUtils = BufferUtils;
@@ -30,14 +27,6 @@ Platform.WebStorage = WebStorage;
 Rest.Crypto = Crypto;
 Realtime.Crypto = Crypto;
 
-Rest.Message = Message;
-Realtime.Message = Message;
-
-Rest.PresenceMessage = PresenceMessage;
-Realtime.PresenceMessage = PresenceMessage;
-
-Realtime.ConnectionManager = ConnectionManager;
-
 Logger.initLogHandlers();
 
 Platform.Defaults = getDefaults(PlatformDefaults);

diff --git a/src/platform/web-noencryption/index.ts b/src/platform/web-noencryption/index.ts
@@ -12,12 +12,9 @@ import Config from '../web/config';
 import Transports from '../web/lib/transport';
 import Logger from '../../common/lib/util/logger';
 import { getDefaults } from '../../common/lib/util/defaults';
-import ConnectionManager from '../../common/lib/transport/connectionmanager';
 import WebStorage from '../web/lib/util/webstorage';
 import PlatformDefaults from '../web/lib/util/defaults';
 import msgpack from '../web/lib/util/msgpack';
-import Message from 'common/lib/types/message';
-import PresenceMessage from 'common/lib/types/presencemessage';
 
 Platform.Crypto = null;
 Platform.BufferUtils = BufferUtils;
@@ -29,14 +26,6 @@ Platform.WebStorage = WebStorage;
 Rest.Crypto = null;
 Realtime.Crypto = null;
 
-Rest.Message = Message;
-Realtime.Message = Message;
-
-Rest.PresenceMessage = PresenceMessage;
-Realtime.PresenceMessage = PresenceMessage;
-
-Realtime.ConnectionManager = ConnectionManager;
-
 Logger.initLogHandlers();
 
 Platform.Defaults = getDefaults(PlatformDefaults);

diff --git a/src/platform/web/index.ts b/src/platform/web/index.ts
@@ -13,12 +13,9 @@ import Config from './config';
 import Transports from './lib/transport';
 import Logger from '../../common/lib/util/logger';
 import { getDefaults } from '../../common/lib/util/defaults';
-import ConnectionManager from '../../common/lib/transport/connectionmanager';
 import WebStorage from './lib/util/webstorage';
 import PlatformDefaults from './lib/util/defaults';
 import msgpack from './lib/util/msgpack';
-import Message from 'common/lib/types/message';
-import PresenceMessage from 'common/lib/types/presencemessage';
 
 Platform.Crypto = Crypto;
 Platform.BufferUtils = BufferUtils;
@@ -30,14 +27,6 @@ Platform.WebStorage = WebStorage;
 Rest.Crypto = Crypto;
 Realtime.Crypto = Crypto;
 
-Rest.Message = Message;
-Realtime.Message = Message;
-
-Rest.PresenceMessage = PresenceMessage;
-Realtime.PresenceMessage = PresenceMessage;
-
-Realtime.ConnectionManager = ConnectionManager;
-
 Logger.initLogHandlers();
 
 Platform.Defaults = getDefaults(PlatformDefaults);