Remove parts of test relating to setOptions calling its callback imme…

…diately

As part of #1213, I’ll be updating this test to use the Promise-based
API, to which the concept of "calls the callback before returning" can’t
be detected, since the JavaScript engine always calls Promise callbacks
asynchronously.

test/realtime/channel.test.js

@@ -686,23 +686,6 @@ define(['ably', 'shared_helper', 'async', 'chai'], function (Ably, helper, async
 
             async.series(
               [
-                function (cb) {
-                  var setOptionsReturned = false;
-                  channel.setOptions(
-                    {
-                      params: params,
-                      modes: modes,
-                    },
-                    function () {
-                      expect(
-                        !setOptionsReturned,
-                        'setOptions failed to call back immediately, when no reattach is required'
-                      ).to.be.ok;
-                      cb();
-                    }
-                  );
-                  setOptionsReturned = true;
-                },
                 function (cb) {
                   channel.attach(cb);
                 },
@@ -715,7 +698,6 @@ define(['ably', 'shared_helper', 'async', 'chai'], function (Ably, helper, async
                     channelUpdated = true;
                   });
 
-                  var setOptionsReturned = false;
                   channel.setOptions(
                     {
                       params: params,
@@ -724,10 +706,6 @@ define(['ably', 'shared_helper', 'async', 'chai'], function (Ably, helper, async
                       /* Wait a tick so we don' depend on whether the update event runs the
                        * channelUpdated listener or the setOptions listener first */
                       Ably.Realtime.Platform.Config.nextTick(function () {
-                        expect(
-                          setOptionsReturned,
-                          'setOptions should return immediately and call back after the reattach'
-                        ).to.be.ok;
                         expect(
                           channelUpdated,
                           'Check channel went to the server to update the channel params'
@@ -736,42 +714,24 @@ define(['ably', 'shared_helper', 'async', 'chai'], function (Ably, helper, async
                       });
                     }
                   );
-                  setOptionsReturned = true;
                 },
                 function (cb) {
                   var channelUpdated = false;
                   channel._allChannelChanges.on(['attached', 'update'], function () {
                     channelUpdated = true;
                   });
 
-                  var setOptionsReturned = false;
                   channel.setOptions(
                     {
                       modes: modes,
                     },
                     function () {
                       Ably.Realtime.Platform.Config.nextTick(function () {
-                        expect(
-                          setOptionsReturned,
-                          'setOptions should return immediately and call back after the reattach'
-                        ).to.be.ok;
                         expect(channelUpdated, 'Check channel went to the server to update the channel mode').to.be.ok;
                         cb();
                       });
                     }
                   );
-                  setOptionsReturned = true;
-                },
-                function (cb) {
-                  var setOptionsReturned = false;
-                  channel.setOptions({}, function () {
-                    expect(
-                      !setOptionsReturned,
-                      'setOptions failed to call back immediately, when no reattach is required'
-                    ).to.be.ok;
-                    cb();
-                  });
-                  setOptionsReturned = true;
                 },
               ],
               function (err) {