Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert REST code to use Promises internally #1528

Closed
lawrence-forooghian opened this issue Dec 5, 2023 · 2 comments
Closed

Convert REST code to use Promises internally #1528

lawrence-forooghian opened this issue Dec 5, 2023 · 2 comments
Assignees
@lawrence-forooghian

Comments

@lawrence-forooghian
Copy link
Collaborator

src/common/lib/client/baseclient.ts — just calls through to rest on stats, time, request
src/common/lib/client/paginatedresource.ts — quite a lot
src/common/lib/client/resource.ts — quite a lot
src/common/lib/client/push.ts — quite a lot
src/common/lib/client/rest.ts — quite a lot
src/common/lib/client/restchannel.ts — not a lot
src/common/lib/client/restchannelmixin.ts — not a lot
src/common/lib/client/restpresence.ts — not a lot
src/common/lib/client/restpresencemixin.ts — not a lot
@sync-by-unito Sync by Unito
Copy link

sync-by-unito bot commented Dec 5, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3977

@lawrence-forooghian lawrence-forooghian self-assigned this Dec 7, 2023
lawrence-forooghian added a commit that referenced this issue Jan 8, 2024
@lawrence-forooghian
wip convert Resource.do to use promises
6490e2b 
Resolves #1528.
lawrence-forooghian added a commit that referenced this issue Jan 8, 2024
@lawrence-forooghian
wip convert Resource.do to use promises
e967275 
Resolves #1528.
lawrence-forooghian added a commit that referenced this issue Jan 8, 2024
@lawrence-forooghian
wip convert Resource.do to use promises
06ab05f 
Resolves #1528.
lawrence-forooghian added a commit that referenced this issue Jan 8, 2024
@lawrence-forooghian
wip convert Resource.do to use promises
d985dbe 
Resolves #1528.
lawrence-forooghian added a commit that referenced this issue Jan 8, 2024
@lawrence-forooghian
wip convert Resource.do to use promises
2bb13ff 
Resolves #1528.
lawrence-forooghian added a commit that referenced this issue Jan 9, 2024
@lawrence-forooghian
wip convert Resource.do to use promises
8a912d2 
Resolves #1528.
lawrence-forooghian added a commit that referenced this issue Jan 9, 2024
@lawrence-forooghian
wip convert Resource.do to use promises
583321e 
Resolves #1528.
@lawrence-forooghian lawrence-forooghian mentioned this issue Jan 9, 2024
Merged
lawrence-forooghian added a commit that referenced this issue Jan 9, 2024
@lawrence-forooghian
Convert Resource.do to use promises
8003057 
Resolves #1528.
lawrence-forooghian added a commit that referenced this issue Jan 9, 2024
@lawrence-forooghian
Convert Resource.do to use promises
512a359 
Resolves #1528.
lawrence-forooghian added a commit that referenced this issue Jan 9, 2024
@lawrence-forooghian
Convert Resource.do to use promises
48b95be 
Resolves #1528.
lawrence-forooghian added a commit that referenced this issue Jan 11, 2024
@lawrence-forooghian
Convert Resource.do to use promises
57bd854 
Resolves #1528.
lawrence-forooghian added a commit that referenced this issue Jan 11, 2024
@lawrence-forooghian
Convert Resource.do to use promises
e572cea 
Resolves #1528.
lawrence-forooghian added a commit that referenced this issue Jan 15, 2024
@lawrence-forooghian
Convert Resource.do to use promises
4dbcbd0 
Resolves #1528.
lawrence-forooghian added a commit that referenced this issue Jan 15, 2024
@lawrence-forooghian
Convert Resource.do to use promises
8436ba5 
Resolves #1528.
lawrence-forooghian added a commit that referenced this issue Jan 15, 2024
@lawrence-forooghian
Convert Resource.do to use promises
470857d 
Resolves #1528.
lawrence-forooghian added a commit that referenced this issue Jan 16, 2024
@lawrence-forooghian
Convert Resource.do to use promises
4f6a0fb 
Resolves #1528.

TODO put the _err renaming in comments into previous commit
lawrence-forooghian added a commit that referenced this issue Jan 26, 2024
@lawrence-forooghian
Convert Resource.do to use promises
0a30b76 
Resolves #1528.
lawrence-forooghian added a commit that referenced this issue Jan 26, 2024
@lawrence-forooghian
Convert Resource.do to use promises
e83b481 
Resolves #1528.
lawrence-forooghian added a commit that referenced this issue Jan 29, 2024
@lawrence-forooghian
Convert Resource.do to use promises
16965e9 
Resolves #1528.
lawrence-forooghian added a commit that referenced this issue Jan 30, 2024
@lawrence-forooghian
Convert Resource.do to use promises
4951ec1 
Resolves #1528.
@lawrence-forooghian
Copy link
Collaborator Author

Resolved by #1541.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lawrence-forooghian lawrence-forooghian

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lawrence-forooghian