Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PaginatedResult.next() is returning undefined instead of null when there's no next page #1542

Closed
lawrence-forooghian opened this issue Dec 11, 2023 · 1 comment · Fixed by #1543
Closed

PaginatedResult.next() is returning undefined instead of null when there's no next page #1542

lawrence-forooghian opened this issue Dec 11, 2023 · 1 comment · Fixed by #1543
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@lawrence-forooghian
Copy link
Collaborator

Per TG4 it's meant to return null, but it returns undefined.
@lawrence-forooghian lawrence-forooghian added the bug Something isn't working. It's clear that this does need to be fixed. label Dec 11, 2023
lawrence-forooghian added a commit that referenced this issue Dec 11, 2023
@lawrence-forooghian
Fix PaginatedResult.next() behaviour when no next page
b3df0a4 
It is meant to return `null` (per TG4 and our documentation comments),
but was returning `undefined`.

Resolves #1542.
@lawrence-forooghian lawrence-forooghian mentioned this issue Dec 11, 2023
Merged
@sync-by-unito Sync by Unito
Copy link

sync-by-unito bot commented Dec 11, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3990

lawrence-forooghian added a commit that referenced this issue Dec 11, 2023
@lawrence-forooghian
Fix PaginatedResult.next() behaviour when no next page
8bd1706 
It is meant to return `null` (per TG4 and our documentation comments),
but was returning `undefined`.

Resolves #1542.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SDK-3990] Fix PaginatedResult.next() behaviour when no next page ably/ably-js
1 participant
@lawrence-forooghian