Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade TypeScript to 4.9.5 #1258

Merged
merged 1 commit into from
May 15, 2023

Conversation

lawrence-forooghian
Copy link
Collaborator

@lawrence-forooghian lawrence-forooghian commented May 11, 2023

I want to use the satsifies operator introduced in 4.9.

Ran npm install typescript@4.9.5 typedoc@latest, and then upgraded @types/node to ^18.0.0, to fix microsoft/TypeScript#51567.

The TypeScript upgrade introduced one compilation error, which I’ve fixed here.

I’m targeting the v2 integration branch (which uses the latest webpack) since trying to upgrade TypeScript on main is giving some webpack errors that don’t seem worth trying to understand.

@github-actions github-actions bot temporarily deployed to staging/pull/1258/features May 11, 2023 18:51 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1258/bundle-report May 11, 2023 18:53 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1258/typedoc May 11, 2023 18:53 Inactive
I want to use the `satsifies` operator introduced in 4.9 [1].

Ran `npm install typescript@4.9.5 typedoc@latest`, and then upgraded
@types/node to ^18.0.0, to fix [2].

The TypeScript upgrade introduced one compilation error, which I’ve
fixed here.

I’m targeting the v2 integration branch (which uses the latest webpack)
since trying to upgrade TypeScript on `main` is giving some webpack
errors that don’t seem worth trying to understand.

[1] https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-9.html#the-satisfies-operator
[2] microsoft/TypeScript#51567
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lawrence-forooghian lawrence-forooghian merged commit 487914e into integration/v2 May 15, 2023
@lawrence-forooghian lawrence-forooghian deleted the upgrade-typescript-to-4.9.5 branch May 15, 2023 11:51
@VeskeR VeskeR mentioned this pull request Mar 1, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants