Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-3707] build: use esbuild for web bundles #1369

Merged
merged 7 commits into from
Jul 19, 2023
Merged

[SDK-3707] build: use esbuild for web bundles #1369

merged 7 commits into from
Jul 19, 2023

Conversation

owenpearson
Copy link
Member

Resolves #1367

@github-actions github-actions bot temporarily deployed to staging/pull/1369/features June 30, 2023 14:00 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1369/bundle-report June 30, 2023 14:01 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1369/typedoc June 30, 2023 14:02 Inactive
@owenpearson owenpearson marked this pull request as draft July 3, 2023 12:28
@owenpearson
deps: add esbuild dependency
3bb7623
@owenpearson
deps: add esbuild-plugin-umd-wrapper dependency
27d0653 
this is needed for legacy platform support - esbuild only supports iife,
esm, and commonjs out of the box
@github-actions github-actions bot temporarily deployed to staging/pull/1369/features July 7, 2023 15:20 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1369/features July 7, 2023 15:31 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1369/typedoc July 7, 2023 15:32 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1369/bundle-report July 7, 2023 15:32 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1369/features July 10, 2023 15:28 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1369/typedoc July 10, 2023 15:29 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1369/bundle-report July 10, 2023 15:29 Inactive
@owenpearson
ci: remove closure compiler check
ed9be58 
not needed since we are no longer targeting lower ES levels
@owenpearson
build: use esbuild for browser bundles
4d22ee2
@owenpearson owenpearson marked this pull request as ready for review July 10, 2023 16:36
@owenpearson owenpearson changed the base branch from integration/v2 to xhr-transports-typescript July 11, 2023 11:40
Base automatically changed from xhr-transports-typescript to integration/v2 July 12, 2023 09:19
lawrence-forooghian
lawrence-forooghian approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@lawrence-forooghian lawrence-forooghian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not knowledgeable about esbuild, but given that the tests are passing I'm assuming it's all good 👍

src/platform/web/lib/util/webstorage.ts Show resolved Hide resolved
src/common/lib/transport/connectionmanager.ts Show resolved Hide resolved
@owenpearson owenpearson mentioned this pull request Jul 19, 2023
Open
@owenpearson owenpearson merged commit c508a39 into integration/v2 Jul 19, 2023
@owenpearson owenpearson deleted the esbuild branch July 19, 2023 10:06
@hayleynewton hayleynewton changed the title build: use esbuild for web bundles [SDK-3707] build: use esbuild for web bundles Jul 27, 2023
@VeskeR VeskeR mentioned this pull request Mar 1, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lawrence-forooghian lawrence-forooghian lawrence-forooghian approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owenpearson @lawrence-forooghian