Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Node 12 and es5 code that was supporting older platforms in v2 #1641

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Remove Node 12 and es5 code that was supporting older platforms in v2 #1641

merged 3 commits into from
Mar 6, 2024
+8,153 −11,034

Commits on Mar 6, 2024

  1. Set trailingComma in .prettierrc to all and run npm run format 

    Related to 9a05dc8, we now allow prettier
to put trailing commas in more places that were not supported in ES5,
and only became available in ES2017 [1], namingly: function parameters
and function calls. This also enables trailing commas in type parameters
in TypeScript - supported since TypeScript 2.7.

[1] https://prettier.io/docs/en/options.html#trailing-commas
    @VeskeR
    VeskeR committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    e12d300 View commit details
    Browse the repository at this point in the history

  2. Remove Node 12 specific code from webpack config for MochaJUnitReporter 

    Also run `npm uninstall babel-loader @babel/preset-env`, we don't use
them anymore after removing Node 12 code from webpack for
MochaJUnitReporter.
    @VeskeR
    VeskeR committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    9f7669d View commit details
    Browse the repository at this point in the history

  3. Remove MochaJUnitReporter bundle for Node.js in webpack 

    After 4f887c6 there is no need anymore
to build a separate MochaJUnitReporter bundle for Node.js - we can use
`mocha-junit-reporter` package directly from Node.

As a result, we also don't need `webpack-node-externals` package
anymore, so run `npm uninstall webpack-node-externals`
    @VeskeR
    VeskeR committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    8b387f2 View commit details
    Browse the repository at this point in the history