Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change PresenceEnterResult to PresenceResult in react hooks #1697

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

VeskeR
Copy link
Contributor

@VeskeR VeskeR commented Mar 15, 2024

This was wrongfully renamed in 730c621. It is a remnant of a usePresenceEnter name for the new hook, which was temporary used during development in #1674, but we decided to keep the name usePresence.

This was wrongfully renamed in 730c621. It is a remnant
of a `usePresenceEnter` name for the new hook, which was temporary used
during development in #1674,
but we decided to keep the name `usePresence`.
Copy link
Collaborator

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spot!

@VeskeR VeskeR merged commit a3389a8 into integration/v2 Mar 15, 2024
9 of 12 checks passed
@VeskeR VeskeR deleted the fix-presence-enter-name branch March 15, 2024 13:30
@VeskeR VeskeR mentioned this pull request Mar 18, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants