Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add migration guide for react hooks for ably-js v2 #1698

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Add migration guide for react hooks for ably-js v2 #1698

merged 2 commits into from
Mar 21, 2024

Conversation

VeskeR
Copy link
Contributor

@VeskeR VeskeR commented Mar 15, 2024

Resolves #1684

@VeskeR VeskeR requested review from ttypic and owenpearson March 15, 2024 10:51
@github-actions github-actions bot temporarily deployed to staging/pull/1698/features March 15, 2024 10:51 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1698/bundle-report March 15, 2024 10:52 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1698/typedoc March 15, 2024 10:52 Inactive
VeskeR
VeskeR commented Mar 15, 2024
View reviewed changes
docs/react-migration-guide.md Outdated Show resolved Hide resolved
@VeskeR VeskeR force-pushed the 1684/react-hooks-v2-migration-guide branch from 95d78bd to eec436b Compare March 15, 2024 13:50
@github-actions github-actions bot temporarily deployed to staging/pull/1698/features March 15, 2024 13:51 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1698/bundle-report March 15, 2024 13:51 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1698/typedoc March 15, 2024 13:51 Inactive
@VeskeR VeskeR force-pushed the 1684/react-hooks-v2-migration-guide branch from eec436b to 1c5d80d Compare March 15, 2024 13:51
@github-actions github-actions bot temporarily deployed to staging/pull/1698/features March 15, 2024 13:52 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1698/typedoc March 15, 2024 13:52 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1698/bundle-report March 15, 2024 13:52 Inactive
owenpearson
owenpearson approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A few (optional) suggestions

docs/react-migration-guide.md Outdated Show resolved Hide resolved
docs/react-migration-guide.md Outdated Show resolved Hide resolved
docs/react-migration-guide.md Outdated Show resolved Hide resolved
VeskeR
VeskeR commented Mar 15, 2024
View reviewed changes
docs/react-migration-guide.md Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to staging/pull/1698/features March 15, 2024 14:45 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1698/bundle-report March 15, 2024 14:46 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1698/typedoc March 15, 2024 14:46 Inactive
jamienewcomb
jamienewcomb approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@jamienewcomb jamienewcomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from a readability perspective

@VeskeR VeskeR force-pushed the 1684/react-hooks-v2-migration-guide branch from 7c5485f to 0def91d Compare March 20, 2024 21:30
@github-actions github-actions bot temporarily deployed to staging/pull/1698/features March 20, 2024 21:30 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1698/bundle-report March 20, 2024 21:31 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1698/typedoc March 20, 2024 21:31 Inactive
@VeskeR VeskeR changed the base branch from integration/v2 to ECO-1416-v2-migration-guide March 20, 2024 21:31
@VeskeR
Copy link
Contributor Author

VeskeR commented Mar 20, 2024 •
edited
Loading

Moved migration guide for React hooks v1 -> v2 to a separate file to conform to the structure introduced in 9ee5681 (part of #1670 PR).

Rebased this PR on top of #1670 to use its formatting improvements added in 1916b4c

ttypic
ttypic reviewed Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@lawrence-forooghian lawrence-forooghian force-pushed the ECO-1416-v2-migration-guide branch 2 times, most recently from c79f906 to b44e629 Compare March 21, 2024 12:20
Base automatically changed from ECO-1416-v2-migration-guide to integration/v2 March 21, 2024 12:23
@VeskeR VeskeR force-pushed the 1684/react-hooks-v2-migration-guide branch from 0def91d to 9e109aa Compare March 21, 2024 13:27
@github-actions github-actions bot temporarily deployed to staging/pull/1698/features March 21, 2024 13:27 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1698/typedoc March 21, 2024 13:28 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1698/bundle-report March 21, 2024 13:28 Inactive
@VeskeR VeskeR force-pushed the 1684/react-hooks-v2-migration-guide branch from 9e109aa to 679e495 Compare March 21, 2024 13:30
@VeskeR VeskeR merged commit 454d1c5 into integration/v2 Mar 21, 2024
11 of 12 checks passed
@VeskeR VeskeR deleted the 1684/react-hooks-v2-migration-guide branch March 21, 2024 13:37
This was referenced Mar 21, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttypic ttypic ttypic approved these changes

@owenpearson owenpearson owenpearson approved these changes

@jamienewcomb jamienewcomb jamienewcomb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VeskeR @ttypic @owenpearson @jamienewcomb