Use useLayoutEffect when calling .setOptions() in ChannelProvider
#1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a temporary fix for #1704. This does not fix the underlying problem of ably-js sending two `ATTACH` messages with the same options when we call `.setOptions()` in `ChannelProvider`. What `useLayoutEffect` accomplishes is it runs before children components' `useEffect` hooks, thus it sets options for a channel before attachment process starts, so there will be no need for reattachment and sending a second `ATTACH` message.
ttypic
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary fix for #1704. This does not fix the underlying problem of ably-js sending two
ATTACHmessages with the same options when we call.setOptions()inChannelProvider.What
useLayoutEffectaccomplishes is it runs before children components'useEffecthooks, thus it sets options for a channel before attachment process starts, so there will be no need for reattachment and sending a secondATTACHmessage.