Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2.0 Feature: Push Notifications: Local Device State #14

Merged
merged 2 commits into from
Sep 6, 2022

Conversation

QuintinWillison
Copy link
Contributor

@QuintinWillison QuintinWillison commented Aug 11, 2022

One of a family of pull requests addressing #3.

Copy link

@qsdstefan qsdstefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way I understood it, Local Device State is now a separate feature as part of the Push Notifications section? Approved.

Base automatically changed from clarify-versioning-state to main August 12, 2022 08:31
@QuintinWillison
Copy link
Contributor Author

Thanks for your comment, @qsdstefan. To address your question:

Local Device State is now a separate feature as part of the Push Notifications section?

The answer is either a light yes or a heavy no, depending on what perspective you look at this from...

The light Yes: From the perspective of someone viewing this with an existing understanding of our IDL and the API structures that it translates to in our SDKs, then "now a separate feature" - describing a move operation - sounds like the correct analysis.

However, this isn't a move. It represents what we already have, from a different angle of view...

The heavy No: From the perspective of the way we're representing our canonical features tree in this repository, I've intentionally deviated from the IDL structure when that is more logical in abstract. The intention is to represent our feature hierarchy in a way that is most logical from a user's perspective, flowing down from node to node. The contents of sdk.yaml is not an IDL or an API.

These feature nodes are intended to be referenced using their fully qualified path into the tree. So, in this case, that's:
Push Notifications: Local Device State

Hopefully an appropriate balance between human and machine readability. 🤞

It's why I implemented the CSS-powered tooltips as you scroll up and down the rendered output:
Screenshot 2022-08-12 at 09 56 26

@QuintinWillison QuintinWillison merged commit f4a458a into main Sep 6, 2022
@QuintinWillison QuintinWillison deleted the push-notifications-local-device-state branch September 6, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants