1.2.0 Feature: Realtime: Channel Modes #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuintinWillison
requested review from
owenpearson,
lmars,
a user,
qsdstefan and
stmoreau
lmars
reviewed
Sep 5, 2022
Base automatically changed from
realtime-delta-subscription-enhancements
to
main
September 9, 2022 08:22
QuintinWillison
force-pushed
the
realtime-channel-modes
branch
from
53c2d68 to
786fe4c
Compare
|
I have made a mistake with Git merges. Trying to resolve. |
… via options for a channel within a Realtime client instance. I could see no evidence that the Ruby SDK supports this.
QuintinWillison
force-pushed
the
realtime-channel-modes
branch
from
462b59b to
266d754
Compare
…mentary contributed by @SimonWoolf.
|
Having addressed @lmars' comment with help from @SimonWoolf, I'm going to merge this pull request without waiting for approval. It has been open for a while and there is a stack of pull requests ahead of it. We are likely to have another look at the entire work at the end, to double check that it congeals holistically, so the risk of merge without approval is low. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could see no evidence that the Ruby SDK supports this.
One of a family of pull requests addressing #3.