1.2.0 Feature: Realtime: Channel State #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… via options for a channel within a Realtime client instance. I could see no evidence that the Ruby SDK supports this.
…nel state changes from Realtime client instances.
QuintinWillison
requested review from
a user,
owenpearson,
lmars,
qsdstefan and
stmoreau
QuintinWillison
removed request for
a user,
lmars,
stmoreau,
qsdstefan and
owenpearson
|
Oops, sorry, converting this back to Draft as I've noticed I had forgotten to include |
|
Hmm, this is ridiculous. Prettier is not failing on my local host. Investigating... 😞 |
|
Locally: |
paddybyers
reviewed
Aug 16, 2022
We were only using it for YAML, in fact. Fighting this tool has taken up too much time. We shall find a replacement. see: #35
QuintinWillison
changed the base branch from
realtime-channel-modes
to
remove-prettier
QuintinWillison
requested review from
owenpearson,
lmars,
qsdstefan and
stmoreau
lmars
reviewed
Sep 5, 2022
QuintinWillison
force-pushed
the
realtime-channel-modes
branch
2 times, most recently
from
462b59b to
266d754
Compare
# Conflicts: # sdk.yaml
|
Having addressed @lmars' and @paddybyers' comments, I'm going to merge this pull request without waiting for approval. It has been open for a while and there is a stack of pull requests ahead of it. We are likely to have another look at the entire work at the end, to double check that it congeals holistically, so the risk of merge without approval is low. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of a family of pull requests addressing #3.
Continues the naming style established in #21 for contexts where state has a synchronous getter as well as an asynchronous event path (e.g.
EventEmitter).