Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine REST: Request Identifiers regarding returned ErrorInfo API #61

Merged
merged 6 commits into from
Sep 30, 2022
Merged

Refine REST: Request Identifiers regarding returned ErrorInfo API #61

merged 6 commits into from
Sep 30, 2022

Conversation

QuintinWillison
Copy link
Contributor

Partially addresses @lmars' observation around the potential oversight of ErrorInfo, specifically the "etc.." including request identifiers for failed requests.

see: #3 (comment)

@QuintinWillison
Expand the synopsis for REST: Request Identifiers to include a key …
854fc4a 
…aspect in respect of the API for returned `ErrorInfo` instances.
@QuintinWillison
Correct the PHP SDK manifest, where it was incorrectly indicating com…
544c745 
…pliance with `REST: Request Identifiers`.
@QuintinWillison
Correct the Java/Android SDK manifest, where it was incorrectly indic…
f481efc 
…ating full compliance with `REST: Request Identifiers`.
@QuintinWillison QuintinWillison self-assigned this Sep 29, 2022
@github-actions github-actions bot temporarily deployed to staging/pull/61/matrix September 29, 2022 10:22 Inactive
@QuintinWillison QuintinWillison marked this pull request as ready for review September 29, 2022 10:23
QSD_amir and others added 2 commits September 29, 2022 13:12
@github-actions github-actions bot temporarily deployed to staging/pull/61/matrix September 29, 2022 12:01 Inactive
@QuintinWillison
Copy link
Contributor Author

I absent-mindedly merged @AmirQSD's PR into the branch underlying this PR. 😞 Sorry, I was on auto-pilot and not concentrating on the target. So the addition of Idempotence to the PHP manifest was never intended to be in scope of this PR. Please overlook, thanks.

@QuintinWillison QuintinWillison mentioned this pull request Sep 29, 2022
Merged
lmars
lmars reviewed Sep 29, 2022
View reviewed changes
sdk.yaml Outdated Show resolved Hide resolved
@QuintinWillison @lmars
Improve grammar in synopsis relating to ErrorInfo and request ident…
b4350ac 
…ifiers.

Co-authored-by: Lewis Marshall <lewis@lmars.net>
@QuintinWillison QuintinWillison merged commit 6b34487 into main Sep 30, 2022
@QuintinWillison QuintinWillison deleted the error-info-request-identifier branch September 30, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmars lmars lmars approved these changes

@owenpearson owenpearson Awaiting requested review from owenpearson

@AmirQSD AmirQSD Awaiting requested review from AmirQSD

@ikbalkaya ikbalkaya Awaiting requested review from ikbalkaya

@stmoreau stmoreau Awaiting requested review from stmoreau

Assignees

@QuintinWillison QuintinWillison

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QuintinWillison @lmars