Expand Channel: Publish feature nodes for REST and Realtime
#72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and Realtime Channel Publish features.
QuintinWillison
requested review from
lmars,
owenpearson,
Peter-Maguire and
stmoreau
QuintinWillison
added a commit
that referenced
this pull request
Oct 12, 2022
…eature nodes that rely on it. Related: #72
This was referenced Oct 12, 2022
owenpearson
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses @lmars' observation around the potential oversight of "Publish message with name", as well as "Publish multiple messages".
see: #3 (comment)
Having discussed this with @owenpearson, @Peter-Maguire and @stmoreau earlier today - we agreed that it would be incomplete for an SDK to implement publish for either REST or Realtime without offering all of the overloads we advertise under RSL1a.
Also, related, but not in this PR...
I queried the purpose of RSL1l (see this internal Slack thread) which has resulted in #73, that adds a new feature node for that overload (REST only).
I am yet to explore whether we need one or more feature nodes adding in response to observations that we may be missing "Publish message with headers in extras" and "Publish message with references in extras", which feel related.